diff options
author | Treehugger Robot <treehugger-gerrit@google.com> | 2020-03-16 05:35:13 +0100 |
---|---|---|
committer | Gerrit Code Review <noreply-gerritcodereview@google.com> | 2020-03-16 05:35:13 +0100 |
commit | 4577dff5a0bb2b008a3454171898527174a71f74 (patch) | |
tree | 7ba237f7c11934cddd8072a3ada3d9c7a8379a54 | |
parent | Merge "Consolidate the wait in recovery's reboot" (diff) | |
parent | Address the warnings in recovery code (diff) | |
download | android_bootable_recovery-4577dff5a0bb2b008a3454171898527174a71f74.tar android_bootable_recovery-4577dff5a0bb2b008a3454171898527174a71f74.tar.gz android_bootable_recovery-4577dff5a0bb2b008a3454171898527174a71f74.tar.bz2 android_bootable_recovery-4577dff5a0bb2b008a3454171898527174a71f74.tar.lz android_bootable_recovery-4577dff5a0bb2b008a3454171898527174a71f74.tar.xz android_bootable_recovery-4577dff5a0bb2b008a3454171898527174a71f74.tar.zst android_bootable_recovery-4577dff5a0bb2b008a3454171898527174a71f74.zip |
-rw-r--r-- | applypatch/imgdiff.cpp | 6 | ||||
-rw-r--r-- | edify/include/edify/expr.h | 2 | ||||
-rw-r--r-- | updater/include/private/commands.h | 2 |
3 files changed, 5 insertions, 5 deletions
diff --git a/applypatch/imgdiff.cpp b/applypatch/imgdiff.cpp index 6ad4a6105..91007ac3b 100644 --- a/applypatch/imgdiff.cpp +++ b/applypatch/imgdiff.cpp @@ -965,7 +965,7 @@ bool ZipModeImage::SplitZipModeImageWithLimit(const ZipModeImage& tgt_image, used_src_ranges.Insert(src_ranges); split_src_ranges->push_back(std::move(src_ranges)); } - src_ranges.Clear(); + src_ranges = {}; // We don't have enough space for the current chunk; start a new split image and handle // this chunk there. @@ -1035,7 +1035,7 @@ bool ZipModeImage::AddSplitImageFromChunkList(const ZipModeImage& tgt_image, } ZipModeImage split_tgt_image(false); - split_tgt_image.Initialize(std::move(aligned_tgt_chunks), {}); + split_tgt_image.Initialize(aligned_tgt_chunks, {}); split_tgt_image.MergeAdjacentNormalChunks(); // Construct the dummy source file based on the src_ranges. @@ -1051,7 +1051,7 @@ bool ZipModeImage::AddSplitImageFromChunkList(const ZipModeImage& tgt_image, CHECK(!src_content.empty()); ZipModeImage split_src_image(true); - split_src_image.Initialize(split_src_chunks, std::move(src_content)); + split_src_image.Initialize(split_src_chunks, src_content); split_tgt_images->push_back(std::move(split_tgt_image)); split_src_images->push_back(std::move(split_src_image)); diff --git a/edify/include/edify/expr.h b/edify/include/edify/expr.h index cd9c70120..3ddf7f5fe 100644 --- a/edify/include/edify/expr.h +++ b/edify/include/edify/expr.h @@ -60,7 +60,7 @@ struct Value { BLOB = 2, }; - Value(Type type, const std::string& str) : type(type), data(str) {} + Value(Type type, std::string str) : type(type), data(std::move(str)) {} Type type; std::string data; diff --git a/updater/include/private/commands.h b/updater/include/private/commands.h index 79f915434..7a23bb78b 100644 --- a/updater/include/private/commands.h +++ b/updater/include/private/commands.h @@ -307,7 +307,7 @@ class Command { : type_(type), index_(index), cmdline_(std::move(cmdline)), - patch_(std::move(patch)), + patch_(patch), target_(std::move(target)), source_(std::move(source)), stash_(std::move(stash)) {} |