| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
| |
Replaced them with fmt::format calls, including changes to the format strings. Also changed the format strings to use FMT_STRING, so that the format is checked compile-time against the arguments.
Also fixed code-style violations already present in the code.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Alpha-sort cChestEntity
* Chests: use SendUpdateBlockEntity
* Pathfinder: fix out of range Y
* 1.13: correct weather packet ID
* Chests: fix neighbour scanner
+ Add OnAddToWorld and overload to scan neighbours there, instead of in the constructor/OnUse. This fixes hoppers accessing newly loaded double chests and seeing a null m_Neighbour, thus thinking its a single chest.
* Fix typo in cross coords computation.
* Simplify hopper logic.
* Block entities: ASSERT that type is correct
If you match the block type first before calling DoWithBlockEntity, the corresponding block entity must either be empty or correspond to the block type.
* Chunk: fix some forgotten PendingSendBE cleanup
+ Add cleanup in SetAllData, WriteBlockArea
- Remove RemoveBlockEntity (used once), HasBlockEntity (not used)
* Replace MakeIndex with MakeIndexNoCheck
* Remove extraneous MarkDirty in hopper & chests
|
| |
|
| |
* replace push_back with emplace_back when a new object was created in the function call
|
| |
|
| |
Use the standard NDEBUG.
|
| | |
|
| |
|
|
|
|
|
|
|
| |
The BlockID.h file was removed from Globals.h and renamed to BlockType.h (main change)
The BlockInfo.h file was removed from Globals.h (main change)
The ENUM_BLOCK_ID and ENUM_ITEM_ID enum names were replaced with ENUM_BLOCK_TYPE and ENUM_ITEM_TYPE (cosmetics)
The various enums, such as eDimension, eDamageType and eExplosionSource were moved from BlockType.h to Defines.h, together with the helper functions for converting between them and strings (StringToDimension et al.) (minor)
Many inline functions were moved from headers to their respective cpp files, so that BlockType.h could be included only into the cpp file, rather than the header.
That broke our tests a bit, since they pick bits and pieces out of the main code and provide stubs for the rest; they had to be re-stubbed and re-verified.
eMonsterType values are no longer tied to E_ITEM_SPAWN_EGG_META_* values
|
| |
|
|
| |
Add check for number of empty lines between functions and fix the corresponding failures
|
| |
|
|
|
| |
- Added override keyword
- Removed inherited member variables
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
Spaces around some operators are checked.
|
| |
|
|
| |
Only when the block around the cave is sand.
|
| | |
|
| | |
|
| |
|
|
| |
As reported by Coverity, these weren't initialized.
|
| |
|
|
| |
I might have forgotten some of them though
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
| |
This was mostly done automatically and then visually inspected for obvious errors.
All //-style comments should have a 2-space separation from the code, and 1 space after the comment sign.
|
| | |
|
| | |
|
| |
|
|
| |
Ref.: #987.
|
| | |
|
| | |
|
| |
|
|
| |
Now they are all Finishers. Fixes #398.
|
| | |
|
| | |
|
| |
|
|
|
| |
Conflicts:
GNUmakefile
|
| |
|
