From 13144a08e496b89b34093ffd3d810d3442df3c44 Mon Sep 17 00:00:00 2001 From: peterbell10 Date: Thu, 14 May 2020 23:15:35 +0100 Subject: Enable some more clang-tidy linter checks (#4738) * Avoid inefficient AString -> c_str() -> AString round trip * Avoid redundant string init expressions * Avoid unnecessary return, continue, etc. * Add .clang-format to help with clang-tidy fix-its * Avoid unnecessary passing by value * Avoid unnecessary local copying * Avoid copying in range-for loops * Avoid over-complicated boolean expressions * Some violations missed by my local clang-tidy * Allow unnecessary continue statements * Add brackets * Another expression missed locally * Move BindingsProcessor call into clang-tidy.sh and add space * Fix pushd not found error * Different grouping of CheckBlockInteractionRate --- .clang-tidy | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) (limited to '.clang-tidy') diff --git a/.clang-tidy b/.clang-tidy index b86487175..fe2716075 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -1,4 +1,13 @@ -Checks: '-*,readability-identifier-naming' +Checks: >- + -*, + readability-identifier-naming, + readability-redundant-string-cstr, + readability-redundant-string-init, + readability-simplify-boolean-expr, + performance-unnecessary-value-param, + performance-unnecessary-copy-initialization, + performance-for-range-copy, + performance-implicit-conversion-in-loop, CheckOptions: - key: readability-identifier-naming.PrivateMemberPrefix value: 'm_' @@ -13,5 +22,9 @@ CheckOptions: # value: CamelCase #- key: readability-identifier-naming.EnumCase # value: camelBack + +- key: performance-unnecessary-value-param.AllowedTypes + value: 'cEntityEffect;cNoise' WarningsAsErrors: '*' HeaderFilterRegex: '/cuberite/src/\.?[^\.]' +FormatStyle: 'file' -- cgit v1.2.3