From 804c3ba6e9e8f51f49df7cd85e547a8ff0c8bb5b Mon Sep 17 00:00:00 2001 From: Tiger Wang Date: Sat, 9 May 2020 14:56:39 +0100 Subject: Upgrade to C++17 [CI] (#4716) * Update CI * Reduce one build to minimum cmake version * Update compile instructions with new minimum versions * Update more guides * Run debug build with VS 2017 Co-authored-by: Peter Bell --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'CONTRIBUTING.md') diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 662a2bbb0..789d3998f 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -14,7 +14,7 @@ When contributing, you must follow our code conventions. Otherwise, CI builds wi Here are the conventions: - - We use the subset of C++11 supported by MSVC 2013 (ask if you think that something outside of this subset would be useful) + - We use C++17. - All new public functions in all classes need documenting comments on what they do and what behavior they follow, use doxy-comments formatted as `/** Description */`. Do not use asterisks on additional lines in multi-line comments. - Use spaces after the comment markers: `// Comment` instead of `//Comment`. A comment must be prefixed with two spaces if it's on the same line with code: - `SomeFunction()//Note the two spaces prefixed to me and the space after the slashes.` -- cgit v1.2.3