From 13144a08e496b89b34093ffd3d810d3442df3c44 Mon Sep 17 00:00:00 2001 From: peterbell10 Date: Thu, 14 May 2020 23:15:35 +0100 Subject: Enable some more clang-tidy linter checks (#4738) * Avoid inefficient AString -> c_str() -> AString round trip * Avoid redundant string init expressions * Avoid unnecessary return, continue, etc. * Add .clang-format to help with clang-tidy fix-its * Avoid unnecessary passing by value * Avoid unnecessary local copying * Avoid copying in range-for loops * Avoid over-complicated boolean expressions * Some violations missed by my local clang-tidy * Allow unnecessary continue statements * Add brackets * Another expression missed locally * Move BindingsProcessor call into clang-tidy.sh and add space * Fix pushd not found error * Different grouping of CheckBlockInteractionRate --- src/Generating/FinishGen.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/Generating/FinishGen.h') diff --git a/src/Generating/FinishGen.h b/src/Generating/FinishGen.h index 4dfd35a7c..22292d924 100644 --- a/src/Generating/FinishGen.h +++ b/src/Generating/FinishGen.h @@ -104,7 +104,7 @@ public: BiomeInfo(int a_MinNumClumpsPerChunk, int a_MaxNumClumpsPerChunk, std::vector a_Blocks) : m_MinNumClumpsPerChunk(a_MinNumClumpsPerChunk), m_MaxNumClumpsPerChunk(a_MaxNumClumpsPerChunk), - m_Blocks(a_Blocks) + m_Blocks(std::move(a_Blocks)) {} }; @@ -118,7 +118,7 @@ public: /** Parses a string and puts a vector with a length of biMaxVariantBiome in a_Output. The format of the string is ";". This can also be repeated with a | */ - static void ParseConfigurationString(AString a_String, std::vector & a_Output); + static void ParseConfigurationString(const AString & a_String, std::vector & a_Output); /** Parses an inifile in search for all clumps */ static std::vector ParseIniFile(cIniFile & a_IniFile, AString a_ClumpPrefix); -- cgit v1.2.3