From 13144a08e496b89b34093ffd3d810d3442df3c44 Mon Sep 17 00:00:00 2001 From: peterbell10 Date: Thu, 14 May 2020 23:15:35 +0100 Subject: Enable some more clang-tidy linter checks (#4738) * Avoid inefficient AString -> c_str() -> AString round trip * Avoid redundant string init expressions * Avoid unnecessary return, continue, etc. * Add .clang-format to help with clang-tidy fix-its * Avoid unnecessary passing by value * Avoid unnecessary local copying * Avoid copying in range-for loops * Avoid over-complicated boolean expressions * Some violations missed by my local clang-tidy * Allow unnecessary continue statements * Add brackets * Another expression missed locally * Move BindingsProcessor call into clang-tidy.sh and add space * Fix pushd not found error * Different grouping of CheckBlockInteractionRate --- src/Item.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/Item.cpp') diff --git a/src/Item.cpp b/src/Item.cpp index dd8f08f02..f1177c84a 100644 --- a/src/Item.cpp +++ b/src/Item.cpp @@ -772,7 +772,7 @@ void cItems::Set(int a_Idx, short a_ItemType, char a_ItemCount, short a_ItemDama bool cItems::Contains(const cItem & a_Item) { - for (auto itr : *this) + for (const auto & itr : *this) { if (a_Item.IsEqual(itr)) { @@ -788,7 +788,7 @@ bool cItems::Contains(const cItem & a_Item) bool cItems::ContainsType(const cItem & a_Item) { - for (auto itr : *this) + for (const auto & itr : *this) { if (a_Item.IsSameType(itr)) { -- cgit v1.2.3