From 13144a08e496b89b34093ffd3d810d3442df3c44 Mon Sep 17 00:00:00 2001 From: peterbell10 Date: Thu, 14 May 2020 23:15:35 +0100 Subject: Enable some more clang-tidy linter checks (#4738) * Avoid inefficient AString -> c_str() -> AString round trip * Avoid redundant string init expressions * Avoid unnecessary return, continue, etc. * Add .clang-format to help with clang-tidy fix-its * Avoid unnecessary passing by value * Avoid unnecessary local copying * Avoid copying in range-for loops * Avoid over-complicated boolean expressions * Some violations missed by my local clang-tidy * Allow unnecessary continue statements * Add brackets * Another expression missed locally * Move BindingsProcessor call into clang-tidy.sh and add space * Fix pushd not found error * Different grouping of CheckBlockInteractionRate --- src/Mobs/PathFinder.cpp | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) (limited to 'src/Mobs/PathFinder.cpp') diff --git a/src/Mobs/PathFinder.cpp b/src/Mobs/PathFinder.cpp index f2542cebc..423c4a0c6 100644 --- a/src/Mobs/PathFinder.cpp +++ b/src/Mobs/PathFinder.cpp @@ -278,9 +278,6 @@ bool cPathFinder::PathIsTooOld() const { acceptableDeviation = 1; } - if ((m_FinalDestination - m_DeviationOrigin).SqrLength() > acceptableDeviation * acceptableDeviation) - { - return true; - } - return false; + const auto DeviationSqr = (m_FinalDestination - m_DeviationOrigin).SqrLength(); + return (DeviationSqr > (acceptableDeviation * acceptableDeviation)); } -- cgit v1.2.3