diff options
author | Sami Tolvanen <samitolvanen@google.com> | 2015-10-19 19:14:01 +0200 |
---|---|---|
committer | Android Git Automerger <android-git-automerger@android.com> | 2015-10-19 19:14:01 +0200 |
commit | a2fcae81301bb67c89bd6d9e88250bae39fd39fc (patch) | |
tree | fa1d47033257805886508b276d398c32bed58919 | |
parent | am 4c6c96a5: am 245b2da1: am 754ebaa9: Merge "updater: Skip empty lines in the transfer list file." (diff) | |
parent | am 78615fa5: Merge "Error correction: Use libfec in blockimg.cpp for recovery" (diff) | |
download | android_bootable_recovery-a2fcae81301bb67c89bd6d9e88250bae39fd39fc.tar android_bootable_recovery-a2fcae81301bb67c89bd6d9e88250bae39fd39fc.tar.gz android_bootable_recovery-a2fcae81301bb67c89bd6d9e88250bae39fd39fc.tar.bz2 android_bootable_recovery-a2fcae81301bb67c89bd6d9e88250bae39fd39fc.tar.lz android_bootable_recovery-a2fcae81301bb67c89bd6d9e88250bae39fd39fc.tar.xz android_bootable_recovery-a2fcae81301bb67c89bd6d9e88250bae39fd39fc.tar.zst android_bootable_recovery-a2fcae81301bb67c89bd6d9e88250bae39fd39fc.zip |
-rw-r--r-- | updater/Android.mk | 3 | ||||
-rw-r--r-- | updater/blockimg.cpp | 76 |
2 files changed, 78 insertions, 1 deletions
diff --git a/updater/Android.mk b/updater/Android.mk index 82fa7e265..dcf437474 100644 --- a/updater/Android.mk +++ b/updater/Android.mk @@ -33,12 +33,13 @@ LOCAL_CLANG := true LOCAL_SRC_FILES := $(updater_src_files) +LOCAL_STATIC_LIBRARIES += libfec libfec_rs libext4_utils_static libsquashfs_utils libcrypto_static + ifeq ($(TARGET_USERIMAGES_USE_EXT4), true) LOCAL_CFLAGS += -DUSE_EXT4 LOCAL_CFLAGS += -Wno-unused-parameter LOCAL_C_INCLUDES += system/extras/ext4_utils LOCAL_STATIC_LIBRARIES += \ - libext4_utils_static \ libsparse_static \ libz endif diff --git a/updater/blockimg.cpp b/updater/blockimg.cpp index 54f2b6ed7..4a813b1d8 100644 --- a/updater/blockimg.cpp +++ b/updater/blockimg.cpp @@ -31,6 +31,7 @@ #include <sys/ioctl.h> #include <time.h> #include <unistd.h> +#include <fec/io.h> #include <memory> #include <string> @@ -1638,8 +1639,83 @@ Value* RangeSha1Fn(const char* name, State* state, int /* argc */, Expr* argv[]) return StringValue(strdup(print_sha1(digest).c_str())); } +Value* BlockImageRecoverFn(const char* name, State* state, int argc, Expr* argv[]) { + Value* arg_filename; + Value* arg_ranges; + + if (ReadValueArgs(state, argv, 2, &arg_filename, &arg_ranges) < 0) { + return NULL; + } + + std::unique_ptr<Value, decltype(&FreeValue)> filename(arg_filename, FreeValue); + std::unique_ptr<Value, decltype(&FreeValue)> ranges(arg_ranges, FreeValue); + + if (filename->type != VAL_STRING) { + ErrorAbort(state, "filename argument to %s must be string", name); + return StringValue(strdup("")); + } + if (ranges->type != VAL_STRING) { + ErrorAbort(state, "ranges argument to %s must be string", name); + return StringValue(strdup("")); + } + + // When opened with O_RDWR, libfec rewrites corrupted blocks when they are read + fec::io fh(filename->data, O_RDWR); + + if (!fh) { + ErrorAbort(state, "fec_open \"%s\" failed: %s", filename->data, strerror(errno)); + return StringValue(strdup("")); + } + + if (!fh.has_ecc() || !fh.has_verity()) { + ErrorAbort(state, "unable to use metadata to correct errors"); + return StringValue(strdup("")); + } + + fec_status status; + + if (!fh.get_status(status)) { + ErrorAbort(state, "failed to read FEC status"); + return StringValue(strdup("")); + } + + RangeSet rs; + parse_range(ranges->data, rs); + + uint8_t buffer[BLOCKSIZE]; + + for (size_t i = 0; i < rs.count; ++i) { + for (size_t j = rs.pos[i * 2]; j < rs.pos[i * 2 + 1]; ++j) { + // Stay within the data area, libfec validates and corrects metadata + if (status.data_size <= (uint64_t)j * BLOCKSIZE) { + continue; + } + + if (fh.pread(buffer, BLOCKSIZE, (off64_t)j * BLOCKSIZE) != BLOCKSIZE) { + ErrorAbort(state, "failed to recover %s (block %d): %s", filename->data, + j, strerror(errno)); + return StringValue(strdup("")); + } + + // If we want to be able to recover from a situation where rewriting a corrected + // block doesn't guarantee the same data will be returned when re-read later, we + // can save a copy of corrected blocks to /cache. Note: + // + // 1. Maximum space required from /cache is the same as the maximum number of + // corrupted blocks we can correct. For RS(255, 253) and a 2 GiB partition, + // this would be ~16 MiB, for example. + // + // 2. To find out if this block was corrupted, call fec_get_status after each + // read and check if the errors field value has increased. + } + } + + return StringValue(strdup("t")); +} + void RegisterBlockImageFunctions() { RegisterFunction("block_image_verify", BlockImageVerifyFn); RegisterFunction("block_image_update", BlockImageUpdateFn); + RegisterFunction("block_image_recover", BlockImageRecoverFn); RegisterFunction("range_sha1", RangeSha1Fn); } |