summaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorbunnei <bunneidev@gmail.com>2022-05-25 22:07:39 +0200
committerGitHub <noreply@github.com>2022-05-25 22:07:39 +0200
commita9beb4746e423e976323fa3866702e0fc977d543 (patch)
treeede945f22168b05518b5b0bfed6e478b6881883b /src
parentMerge pull request #8369 from lat9nq/amd-wmel-workaround (diff)
parentvulkan_device: Block AMDVLK's VK_KHR_push_descriptor (diff)
downloadyuzu-a9beb4746e423e976323fa3866702e0fc977d543.tar
yuzu-a9beb4746e423e976323fa3866702e0fc977d543.tar.gz
yuzu-a9beb4746e423e976323fa3866702e0fc977d543.tar.bz2
yuzu-a9beb4746e423e976323fa3866702e0fc977d543.tar.lz
yuzu-a9beb4746e423e976323fa3866702e0fc977d543.tar.xz
yuzu-a9beb4746e423e976323fa3866702e0fc977d543.tar.zst
yuzu-a9beb4746e423e976323fa3866702e0fc977d543.zip
Diffstat (limited to 'src')
-rw-r--r--src/video_core/vulkan_common/vulkan_device.cpp11
1 files changed, 11 insertions, 0 deletions
diff --git a/src/video_core/vulkan_common/vulkan_device.cpp b/src/video_core/vulkan_common/vulkan_device.cpp
index 58d0c6a93..b3a77e07f 100644
--- a/src/video_core/vulkan_common/vulkan_device.cpp
+++ b/src/video_core/vulkan_common/vulkan_device.cpp
@@ -669,6 +669,17 @@ Device::Device(VkInstance instance_, vk::PhysicalDevice physical_, VkSurfaceKHR
const bool is_amd =
driver_id == VK_DRIVER_ID_AMD_PROPRIETARY || driver_id == VK_DRIVER_ID_AMD_OPEN_SOURCE;
if (is_amd) {
+ // TODO(lat9nq): Add an upper bound when AMD fixes their VK_KHR_push_descriptor
+ const bool has_broken_push_descriptor = VK_VERSION_MAJOR(properties.driverVersion) == 2 &&
+ VK_VERSION_MINOR(properties.driverVersion) == 0 &&
+ VK_VERSION_PATCH(properties.driverVersion) >= 226;
+ if (khr_push_descriptor && has_broken_push_descriptor) {
+ LOG_WARNING(
+ Render_Vulkan,
+ "Disabling AMD driver 2.0.226 and later from broken VK_KHR_push_descriptor");
+ khr_push_descriptor = false;
+ }
+
// AMD drivers need a higher amount of Sets per Pool in certain circunstances like in XC2.
sets_per_pool = 96;
// Disable VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT on AMD GCN4 and lower as it is broken.